Turn by turn reusability refactor and updated designs #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.set in a few scenarios
peterwangxw
approved these changes
Feb 26, 2019
| movementLabel.attributedText = routeInstruction.attributedInstructionString(highlightedTextColor: UIColor(displayP3Red: 4.0/255.0, green: 114.0/255.0, blue: 254.0/255.0, alpha: 1.0), regularTextColor: .darkText) | ||
| } | ||
|
|
||
| private func imageFromDirection(_ direction: PWRouteInstructionDirection) -> UIImage { |
There was a problem hiding this comment.
Should this function be moved into the PWRoute extension? The cell really shouldn't be concerned with resolving the image for a particular route instruction. All it should be concerned about is showing the image. The route instruction extension has all of the relevant information to get the image.
There was a problem hiding this comment.
implemented
pdunshee-phunware
added a commit
that referenced
this pull request
Apr 17, 2019
* Voice prompt and Walk Time Scenarios (#87) * Add voice prompt sample * Voice prompt use language of device, move some walk time calculation into extension * Add voice prompt button design (#88) * Turn by turn reusability refactor and updated designs (#89) * Turn by turn reusability refactor and updated designs. Fixed no PWCore.set in a few scenarios * Move image get to PWRouteInstruction extension * Add Walk Time sample (#90) * Add Walk Time sample * Dynamically calculate user's speed * Code improvement * Code improvement * Instruction list (#91) * Add route instruction list, fix instruction carousel offset bug * Add sample readmes * Add sample readmes * Update sample readmes * Off route sample code scenario * PR changes and read me file added * Fix readme * Update TurnByTurn.md * Update WalkTime.md * When mute tapped, stop reading instruction. When unmute tapped, read … (#94) * When mute tapped, stop reading instruction. When unmute tapped, read current instruction. Fix issues with WalkTime * Check authorization status for always and whenInUse * Incorporate design feedback for off route scenario * Update Walk Time calculation sample * minor tweak * Change the exit button function * Constant for the values used in multiple places * Change the walk time view implementation on the route step list page. * Sample version (#98) * Updating PWMapKit to v3.7.1. See CHANGELOG for details. * Updating PWMapKit to v3.8.0. See CHANGELOG for details. * Update samples to 3.8.0 * Readme updates
pdunshee-phunware
added a commit
that referenced
this pull request
May 20, 2019
* Voice prompt and Walk Time Scenarios (#87) * Add voice prompt sample * Voice prompt use language of device, move some walk time calculation into extension * Add voice prompt button design (#88) * Turn by turn reusability refactor and updated designs (#89) * Turn by turn reusability refactor and updated designs. Fixed no PWCore.set in a few scenarios * Move image get to PWRouteInstruction extension * Add Walk Time sample (#90) * Add Walk Time sample * Dynamically calculate user's speed * Code improvement * Code improvement * Instruction list (#91) * Add route instruction list, fix instruction carousel offset bug * Add sample readmes * Add sample readmes * Update sample readmes * Off route sample code scenario * PR changes and read me file added * Fix readme * Update TurnByTurn.md * Update WalkTime.md * When mute tapped, stop reading instruction. When unmute tapped, read … (#94) * When mute tapped, stop reading instruction. When unmute tapped, read current instruction. Fix issues with WalkTime * Check authorization status for always and whenInUse * Incorporate design feedback for off route scenario * Update Walk Time calculation sample * minor tweak * Change the exit button function * Constant for the values used in multiple places * Change the walk time view implementation on the route step list page. * Sample version (#98) * Updating PWMapKit to v3.7.1. See CHANGELOG for details. * Updating PWMapKit to v3.8.0. See CHANGELOG for details. * Update samples to 3.8.0 * Readme updates * Update turn by turn for blue dot in WalkTime
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed no PWCore.set in a few scenarios