Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Desktop environments use normal hint type and tiling window managers use utility hint type #507

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gort818
Copy link
Contributor

@gort818 gort818 commented Sep 25, 2019

Setting the window hint type to utility does not seem to function well with plasma, peek will not show up in the task manager or task switcher. This checks if the user is using plasma and changes the hint type to normal.

Setting the window hint type to utility does not seem to function well with plasma, peek will not show up in the task manager or task switcher. This checks if the user is using plasma and changes the hint type to normal.
@phw
Copy link
Owner

phw commented Sep 25, 2019

Good catch. Testing this I see this is not only about Plasma, same issue on Gnome. And probably with dock / taskbar implementations in general. I wonder if we should just revert that change and then selectively set the utility flag only for some known tiling window managers. After all the tiling WMs are not really the core target of peek.

@gort818
Copy link
Contributor Author

gort818 commented Sep 25, 2019

Yeah that would probably be a better solution since there a more people using traditional desktop environments.. I could create a list of desktop environments and if a user is not using one in the list is changes to window to utility hint type ... seems easier than testing for each tiling window manager I have no idea how many are being used. what do you think?

@gort818
Copy link
Contributor Author

gort818 commented Sep 26, 2019

OK made a revision let me know if this works for you.

@phw
Copy link
Owner

phw commented Sep 27, 2019

I guess that's ok for now. It kind of inverses my original idea, because I think tiling WMs are probably the special case. But you are right, the desktop environments are probably easier to detect.

@gort818 gort818 changed the title Add fix for kde plasma Make sure Desktop environments use normal hint type and tiling window manager use utility hint type Jan 11, 2021
@gort818 gort818 changed the title Make sure Desktop environments use normal hint type and tiling window manager use utility hint type Make sure Desktop environments use normal hint type and tiling window managers use utility hint type Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants