Add detailed errors for missing Linux syscalls #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds extra handling for I/O errors of the "Unsupported" kind, explicitly pointing out Birdcage's minimum Kernel version for missing system calls. See phylum-dev/cli#1350.
maxrake
reviewed
Feb 7, 2024
maxrake
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
This is an improvement. It is understood that the minimum supported kernel version is not a known constant, given the myriad environments this library could operate within. However, updating documentation to at least provide some additional guidance about why these types of errors could appear and what might be possible to correct them is still desired. That is the other part of the linked issue - phylum-dev/cli#1350 - and may be accomplished in separate PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds extra handling for I/O errors of the "Unsupported" kind, explicitly pointing out Birdcage's minimum Kernel version for missing system calls.
See phylum-dev/cli#1350.