Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cargo lockfile generation sandbox exceptions #1289

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix cargo lockfile generation sandbox exceptions #1289

merged 1 commit into from
Nov 15, 2023

Conversation

cd-work
Copy link
Contributor

@cd-work cd-work commented Nov 15, 2023

Closes #1288.

@cd-work cd-work requested a review from a team as a code owner November 15, 2023 16:49
maxrake
maxrake approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@maxrake maxrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd suggest a CHANGELOG entry, but this is a fix for a feature that was just added (and not part of a release yet). Reviewed the code and tested locally. LGTM.

@cd-work cd-work merged commit 2a260a0 into main Nov 15, 2023
14 checks passed
@cd-work cd-work deleted the cargo_generation_fix branch November 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrake maxrake maxrake approved these changes

@mathew-horner mathew-horner Awaiting requested review from mathew-horner mathew-horner is a code owner automatically assigned from phylum-dev/user-components

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lockfile generation in sandbox broken for cargo on macOS
2 participants
@cd-work @maxrake