Improve robustness of find-permissions extensions #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds two minor changes that should make the `find-permissions` extensions easier to use for people unfamiliar with it. To ensure we don't incorrectly log that `/` is required when the command always fails, the extension now does an explicit check on `/` and outputs a detailed error on the issue. While I wasn't able to reproduce this issue myself, there have been some reports on failures due to permission errors. To avoid the possibility of that we now explicitly handle `Deno.readDir` failures and just assume the corresponding directory is wholly required. To improve consistency, all `console.error` calls have been changed to use red color.
maxrake
previously approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds two minor changes that should make the
find-permissionsextensions easier to use for people unfamiliar with it.To ensure we don't incorrectly log that
/is required when the command always fails, the extension now does an explicit check on/and outputs a detailed error on the issue.While I wasn't able to reproduce this issue myself, there have been some reports on failures due to permission errors. To avoid the possibility of that we now explicitly handle
Deno.readDirfailures and just assume the corresponding directory is wholly required.To improve consistency, all
console.errorcalls have been changed to use red color.