Re-factored to use the official onelogin client #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App ID is reffered by `aws_app_id` in `generate_config`, so should be consistent
|
LGTM. Much cleaner now. |
|
And I agree --- if you can get refresh tokens to work then it'll make things much easier in non-mfa situations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes custom http code and simplifies the code by using the official onelogin python SDK.
This is in relation to #32 . I think the better way to go about extending the session, is rather than try to use AWS to generate longer sts session, use onelogin to re-auth. This is already being done with the
renewSecondsoption, but if MFA is enabled the user must re-enter their MFA tokens every hour. I will propose to use the refresh tokens in onelogin to have longer periods where MFA is not required.Using the onelogin sdk will reduce the amount of code required to do this.
Using a client library will also make generating mocks for tests significantly easier