Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trait#show page reactivity #94

Merged
merged 1 commit into from
Dec 10, 2023
Merged

fix trait#show page reactivity #94

merged 1 commit into from
Dec 10, 2023

Conversation

jamesdabbs
Copy link
Member

@jamesdabbs jamesdabbs commented Dec 10, 2023

per report here

Testing Notes

Copy link

cloudflare-workers-and-pages bot commented Dec 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7d66eed
Status: ✅  Deploy successful!
Preview URL: https://2145b74f.topology.pages.dev
Branch Preview URL: https://jcd-reactive-trait-show.topology.pages.dev

View logs

@jamesdabbs jamesdabbs marked this pull request as ready for review December 10, 2023 19:24
@jamesdabbs jamesdabbs merged commit d9fc44a into main Dec 10, 2023
3 checks passed
@jamesdabbs jamesdabbs deleted the jcd/reactive-trait-show branch December 10, 2023 19:24
jamesdabbs added a commit that referenced this pull request Dec 13, 2023
* format {S#|P#} display (#80)

to include a description of the trait value

* persist data source branch in localStorage (#89)

* persist data source branch in localStorage

* fix compile build failure

which appears to have been introduced through random dependency
drift, not any changes here :/

* cache cypress binary in CI

to fix https://github.com/pi-base/web/actions/runs/7149095438/job/19470902100?pr=89

* fix trait#show page reactivity (#94)

per report [here](https://github.com/orgs/pi-base/discussions/464#discussioncomment-7560692)

* truncate previews at first line break (#96)

* fix filter reactivity (#97)

fixes #77

* add related trait filter url param

* typeset internal links (#99)

* misc. minor style tweaks (#100)

- adjust icon styling
- fix spacing around ,s in alias lists
- correct table header style

* use action verbs in robot toggle (#103)

* Update homepage to promote code4math (#93)

* Update homepage to promote code4math

* typo, formatting

* formatting

* lint

* redirect to normalized ids

---------

Co-authored-by: Steven Clontz <steven.clontz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant