Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the for changing of the UID/GID of the user/group pihole #1403

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Allow the for changing of the UID/GID of the user/group pihole #1403

merged 2 commits into from
Jul 26, 2023

Conversation

PromoFaux
Copy link
Member

What does this PR aim to accomplish?:

Allows for the id of the pihole user and group to be changed. Port of existing functionality from v5 containers

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@PromoFaux
Allow the for changing of the UID/GID of the user/group pihole
62dd8d5 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux
Add tests for UID/GID switching
f09b0d6 
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
@PromoFaux PromoFaux mentioned this pull request Jul 26, 2023
Closed
6 tasks
@PromoFaux PromoFaux requested a review from a team July 26, 2023 07:39
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PromoFaux PromoFaux merged commit e0678bd into development-v6 Jul 26, 2023
7 checks passed
@PromoFaux PromoFaux deleted the v6/change-pihole-userid branch July 26, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PromoFaux