-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create traefik-v2-docker.md #882
Conversation
✅ Deploy Preview for pihole-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I think @PromoFaux uses Traefik, so request his review. |
Overall looks good to me, however the navigation option is missing in the sidebar. It should be added in here: https://github.com/pi-hole/docs/blob/master/mkdocs.yml#L185 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Check it out now @PromoFaux :) |
Current docs for Traefik config seem to be for Traefik v1 so I've provided some for v2. I also have provided 2 scenarios- a) both Traefik and Pi-hole are containers on same Docker host, and b) Traefik is containerized but Pi-hole is remote. Signed-off-by: William Trelawny <22324745+willman42@users.noreply.github.com>
Fixed markdown-lint errors Signed-off-by: William Trelawny <22324745+willman42@users.noreply.github.com>
Added link to Traefik docs Signed-off-by: William Trelawny <22324745+willman42@users.noreply.github.com>
Added "Traefik v2 (with Docker)" and distinguished other Traefik doc link as being for v1. Signed-off-by: William Trelawny <22324745+willman42@users.noreply.github.com>
Current docs for Traefik config seem to be for Traefik v1 so I've provided some for v2.
I also have provided 2 scenarios- a) both Traefik and Pi-hole are containers on same Docker host, and b) Traefik is containerized but Pi-hole is remote.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
Improve docs on using Traefik to proxy Pi-hole web.
How does this PR accomplish the above?:
Providing brand new doc for Traefik v2 which includes Docker config.
By submitting this pull request, I confirm the following:
git rebase
)