Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic-install: document how to continue after SELinux check #3607

Merged
merged 1 commit into from
Sep 17, 2020
Merged

basic-install: document how to continue after SELinux check #3607

merged 1 commit into from
Sep 17, 2020

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Jul 23, 2020

Signed-off-by: Christian Göttsche cgzones@googlemail.com

By submitting this pull request, I confirm the following:
please fill any appropriate checkboxes, e.g: [X]

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes, and have included unit tests where possible.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)

Please make sure you Sign Off all commits. Pi-hole enforces the DCO.


What does this PR aim to accomplish?:
Be able to run the installer with SELinux set to enforced default mode.

How does this PR accomplish the above?:
Output steps how to pass the SELinux check after it has stopped the installation.

What documentation changes (if any) are needed to support this PR?:
A detailed list of any necessary changes

Closes: #3556

@PromoFaux PromoFaux requested a review from bcambl July 23, 2020 14:31
@bcambl
Copy link
Member

bcambl commented Jul 30, 2020

@cgzones Thank you for the PR.
May I please ask you to update the PR to use -n instead of ! -z on the variable test?

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
@bcambl bcambl merged commit 4d98e15 into pi-hole:development Sep 17, 2020
@cgzones cgzones deleted the selinux branch September 17, 2020 11:00
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants