Fix "Never forward non-FQDNs" checkbox #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icked, we add to tell FTL that this domain is purely local and FTL may answer queries from /etc/hosts or DHCP but should never forward queries on that domain to any upstream servers Signed-off-by: DL6ER <dl6er@dl6er.de>
DL6ER
changed the title
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/private-host-names-not-sent-to-upstream-since-v5-3-2/41014/17 |
8 tasks
PromoFaux
approved these changes
Dec 1, 2020
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-1-and-ftl-v5-3-2-released/41148/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
git rebase)What does this PR aim to accomplish?:
When there is a Pi-hole domain set and "Never forward non-FQDNs" is ticked, we add
local=/$domain/to tell FTL that this domain is purely local and FTL may answer queries from/etc/hostsor DHCP but should never forward queries on that domain to any upstream servers.Saving the changed checkbox can currently be seen as broken because it requires you to change the box, save the page and then go to the DHCP settings page and also save this one (w/ or w/o changes doesn't matter).
This bug has been reported on Discourse (see link by Pralor below)
How does this PR accomplish the above?:
Always re-process the DHCP settings when saving the DNS settings to avoid users having to click twice.
What documentation changes (if any) are needed to support this PR?:
None