-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background colors on Query log + switchable text coloring (as before) #1893
Conversation
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
… last release Signed-off-by: Adam Warner <me@adamwarner.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier
failed
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
It still fails 🙃 I'll fix it when merging #1888 into this PR. |
Signed-off-by: DL6ER <dl6er@dl6er.de>
@PromoFaux Please give it another look. I replaced the text variable |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/neues-update-und-farbe-im-querry-log/49755/2 |
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/neues-update-und-farbe-im-querry-log/49755/7 |
Node test passed, the status is hung up here. https://github.com/pi-hole/AdminLTE/actions/runs/1254831670 Okay to merge with admin override. |
@PromoFaux, I have a suggestion: Applying the CSS rule on the
That way, all themes keep the striped visual, and the dark themes still have the hover effect. |
Improves PR #1893 The CSS for the background was created using "!important", to force the background colors for blocked/allowed on the table lines, but this introduced a visual problem: all lines have the same backgrounds. No more striped tables. To solve this, I moved the effect from the `tr` tags to `td` tags. Now the rows (tr) have striped backgrounds and the cells adds the color layer. Signed-off-by: rdwebdesign <github@rdwebdesign.com.br>
By submitting this pull request, I confirm the following:
git rebase
)What does this PR aim to accomplish?:
I'm going to throw a spanner in the works here, been playing about with this as a middle ground using
background-color: rgb(229,83,75,0.1)!important;
for blocked andbackground-color: rgb(70,149,74,0.1)!important;
for allowed