Do not use IPvX from setupVars in $AUTHORIZED_HOSTNAMES #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian König <ckoenig@posteo.de>
8 tasks
rdwebdesign
approved these changes
Jun 4, 2022
yubiuser
added
the
PR: Approved
yubiuser
changed the title
|
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-ftl-v5-16-web-v5-13-and-core-v5-11-1-released/56384/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase)git commit --signoff)What does this PR aim to accomplish?:
We try to get rid of
IPv4_ADDRESSandIPv6_ADDRESSfromsetupVars.conf(pi-hole/pi-hole#4356). This PR removes both addresses from$AUTHORIZED_HOSTNAMESin the CORS check. For details and implications seepi-hole/pi-hole#4356 (comment)