Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig #2231

Merged
merged 1 commit into from
Jun 26, 2022
Merged

Add .editorconfig #2231

merged 1 commit into from
Jun 26, 2022

Conversation

yubiuser
Copy link
Member

  • What does this PR aim to accomplish?:

Adds an .editorconfig which should make coding style coherent between different authors, platforms, IDEs.
This uses the config pi-hole/pi-hole#1349 added to the core repo. I even think this was never meant to go to core but to web....

Fixed #1983


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team June 24, 2022 12:17
@yubiuser yubiuser linked an issue Jun 24, 2022 that may be closed by this pull request
@yubiuser yubiuser force-pushed the editorconfig branch 3 times, most recently from c1bc4e4 to 2225397 Compare June 26, 2022 07:23
Signed-off-by: Christian König <ckoenig@posteo.de>
@PromoFaux PromoFaux merged commit b95a6b0 into devel Jun 26, 2022
@PromoFaux PromoFaux deleted the editorconfig branch June 26, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No .editorconfig in AdminLTE
2 participants