Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show indication on settings causing a restart #2774

Closed
wants to merge 1 commit into from

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 22, 2023

What does this implement/fix?

Add red redo-icon on advanced settings page for settings requiring a restart of FTL

image

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…restart of FTL

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team October 22, 2023 19:06
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be added manually here?

Screenshot at 2023-10-22 21-28-19

@PromoFaux
Copy link
Member

Does it need to be added manually here?

I think not, should be able to do this in the same way I've done it over on new/env_vars_readonly (likewise, we can maybe do the same for advanced)

@PromoFaux
Copy link
Member

Actually, I like that a lot. I'll implement it

@PromoFaux
Copy link
Member

See here: f201ad4 (this commit can be moved to a separate PR after the other one is merged if preferred, but might as well do it all in the same place)

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@DL6ER
Copy link
Member Author

DL6ER commented Nov 4, 2023

Implemented by #2787

@DL6ER DL6ER closed this Nov 4, 2023
@DL6ER DL6ER deleted the tweak/ftl_may_restart branch November 4, 2023 16:42
@yubiuser
Copy link
Member

yubiuser commented Nov 4, 2023

misc.privacylevel does not show the indicator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants