Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark variables set by environment variable as read only in the web interface #2787

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Mark variables set by environment variable as read only in the web interface #2787

merged 5 commits into from
Oct 29, 2023

Commits on Oct 29, 2023

  1. Indicate config settings forced by env vars as read-only variables by… 

    … marking them with a symbol and disabling the elements

Signed-off-by: DL6ER <dl6er@dl6er.de>
    @DL6ER @PromoFaux
    DL6ER authored and PromoFaux committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    619ea8f View commit details
    Browse the repository at this point in the history

  2. Disable settings inputs if they are already set by environment variab… 

    …le. Add a padlock icon to the setting section title if any of the settings contained therin are set by environment variable
    @PromoFaux
    PromoFaux committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    fef945c View commit details
    Browse the repository at this point in the history

  3. In addition to adding the readonly icon, we can also add the other ic… 

    …ons with teh same method.

Signed-off-by: Adam Warner <me@adamwarner.co.uk>
    @PromoFaux
    PromoFaux committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    66401ee View commit details
    Browse the repository at this point in the history

  4. The CI does not like nested IF statements with a single action inside 

    Signed-off-by: Adam Warner <me@adamwarner.co.uk>
    @PromoFaux
    PromoFaux committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b2572c0 View commit details
    Browse the repository at this point in the history

  5. Apply the same treatment to the local DNS records page. 

    Refactor of the javascript to reduce code deduplication
Fix datatable refresh after adding/removing an entry
    @PromoFaux
    PromoFaux committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    188f8ee View commit details
    Browse the repository at this point in the history