Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notification icon and add details for Local DNS/CNAME records #2809

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Fix notification icon and add details for Local DNS/CNAME records #2809

merged 1 commit into from
Nov 6, 2023

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 5, 2023

  1. Fixes the icon displayed in the notifications. Before, it always defaulted to ´fa-clock
  2. Re-adds detail info to the notifications for adding/deleting Local DNS/CNAME records. They have been added by Fix how Bootstrap-Notfy is used by Pi-hole #2786 but where (accidentally) removed by Mark variables set by environment variable as read only in the web interface #2787

Screenshot at 2023-11-05 21-47-14

@yubiuser yubiuser requested a review from a team November 5, 2023 20:58
@yubiuser
Fix notification icon and add details for Local DNS/CNAME records
6f6f0f9 
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser merged commit 917750a into development-v6 Nov 6, 2023
7 checks passed
@yubiuser yubiuser deleted the tweak/notification branch November 6, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

Assignees
No one assigned
Labels
Pi-hole v6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yubiuser @PromoFaux