Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak lists user interface (specially icons) #2876

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?

Separate status and type icons to make easier to identify list status and type.
Try to be consistent regarding block/allow type icons (replacing -/+ with already used icons).

How does this PR accomplish the above?

  • add a new column and separate status and type icons;
  • move the code responsible for the icons to dedicated functions;
  • use the same icons used in the buttons for allow/block: image;
  • use the same style (solid circles) for every status icon: image (except history)

image
Link documentation PRs if any are needed to support this PR:

none


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

- add a new column for list type;
- separate status and type icons;
- move the code responsible for the icons to dedicated functions;
- use the same icons for block/allow everywhere;
- use the same style (solid circle) for every status icon (except history).

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@DL6ER
Copy link
Member

DL6ER commented Nov 27, 2023

While we are improving this page, I have another suggestion: Hovering the type icon shows a tooltip explaining the icon ("This is a blocklist/an allowlist"). However, hovering the status icon only shows the default tooltip of the row ("Click for details about this list"). For consistency, I think both should explain their icon in the first line but also both should mention that you can click on them for further details

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit 8a397e7 into development-v6 Nov 28, 2023
8 checks passed
@rdwebdesign rdwebdesign deleted the tweak/lists_icons branch November 28, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants