Update api.php?setTempUnit function to require authentication #3077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
There was a lack of a check to the $auth variable. This allowed any unauthenticated user to change the CPU temperature unit displayed of the pi-hole application. Adding the check of this variable fixes this issue.
The absence of authentication of this function was deemed not a security risk but maintainers were open to a potential merge depending on the release of v6.
Report: https://github.com/pi-hole/web/security/advisories/GHSA-mffw-5jmg-9wjq
How does this PR accomplish the above?:
Added
&& $auth
authorization check before using setTempUnit parameter to change temperature.Link documentation PRs if any are needed to support this PR:
N/A
By submitting this pull request, I confirm the following:
git rebase
)