Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting algorithm on Query Log page #426

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Fix sorting algorithm on Query Log page #426

merged 2 commits into from
Mar 3, 2017

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 3, 2017

By submitting this pull request, I confirm the following (please check boxes, eg [X] - no spaces) Failure to fill the template will close your PR:

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

{replace this text with a number from 1 to 10, with 1 being not familiar, and 10 being very familiar}


Pull request to master as post-release fix

Bugfix: Sorting algorithm of DataTables is broken, use Momentum.js for filtering

Fixes #425

screenshot at 2017-03-03 16-17-26

This template was created based on the work of udemy-dl.

@DL6ER DL6ER added the Bugfix label Mar 3, 2017
@DL6ER DL6ER added this to the v2.5 milestone Mar 3, 2017
@PromoFaux
Copy link
Member

PromoFaux commented Mar 3, 2017

Approved

Approved with PullApprove

2 similar comments
@dschaper
Copy link
Member

dschaper commented Mar 3, 2017

Approved

Approved with PullApprove

@jacobsalmela
Copy link
Contributor

jacobsalmela commented Mar 3, 2017

Approved

Approved with PullApprove

@DL6ER DL6ER merged commit 078cbb1 into master Mar 3, 2017
@DL6ER DL6ER deleted the fix/QuerySorting branch March 3, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong sort order on Recent Queries page
4 participants