Add firmware check and message during SSH login #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-roberts
changed the title
|
Just thinking about setting this update check as permissable for non-root to work with SSH login... I think that the current sudo requirement is because of the fact that this works with Seems we need to split out the desktop notification management into its own daemon that runs as root so that the check (and update?) script can be invoked as a non-root user. It seems reasonable to either have a flag to determine backend/use-case, or that the desktop notification daemon is only used if it exists with a stdout fallback. Also, 'check' is an infinite service, not a one-shot as is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
This PR attempts to add a message during each SSH login showing if there is a firmware update available.
Still need to parse the command output without invoking desktop notifications, evaluate performance and produce a human-friendly message about what to do if there is an update.