Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost dependency with json only input #80

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Replace boost dependency with json only input #80

merged 3 commits into from
Sep 4, 2024

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Dec 9, 2022

No description provided.

@streeve streeve self-assigned this Dec 9, 2022
@streeve
Copy link
Collaborator Author

streeve commented Dec 12, 2022

retest this please.

@streeve streeve force-pushed the json branch 2 times, most recently from 29602be to 204cde0 Compare April 16, 2024 17:47
dalg24
dalg24 reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@dalg24 dalg24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity what was the motivation for transitioning to that new library?

src/Picasso_AdaptiveMesh.hpp Outdated Show resolved Hide resolved
@streeve
Copy link
Collaborator Author

streeve commented Apr 25, 2024

Out of curiosity what was the motivation for transitioning to that new library?

Boost is pretty heavy dependency for just json parsing. We're also using it in a few other places and I find it easier to work with

@streeve streeve mentioned this pull request Aug 22, 2024
Merged
abisner
abisner reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@abisner abisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed including the ParticleInit test in the unit tests CMakeLists.

CMakeLists.txt Show resolved Hide resolved
src/Picasso_LevelSet.hpp Outdated Show resolved Hide resolved
src/Picasso_ParticleLevelSet.hpp Outdated Show resolved Hide resolved
src/Picasso_UniformMesh.hpp Outdated Show resolved Hide resolved
src/Picasso_UniformMesh.hpp Outdated Show resolved Hide resolved
src/Picasso_UniformMesh.hpp Outdated Show resolved Hide resolved
unit_test/tstParticleList.hpp Outdated Show resolved Hide resolved
unit_test/tstAdaptiveMesh.hpp Show resolved Hide resolved
unit_test/tstParticleInit.hpp Outdated Show resolved Hide resolved
@streeve streeve merged commit 1fc68e7 into picassodev:master Sep 4, 2024
10 checks passed
@streeve streeve deleted the json branch September 4, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalg24 dalg24 dalg24 left review comments

@abisner abisner abisner approved these changes

Assignees

@streeve streeve

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@streeve @dalg24 @abisner