Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the unexpected behavior of InAppWebView and HeadlessInAppWebVie… #1064

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

RodXander
Copy link
Contributor

…w when initialUrlRequest was set as null.

Connection with issue(s)

Resolve issue #1063

Connected to #???

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@myagizguler
Copy link

myagizguler commented Mar 2, 2022

how can I use that commit on my project? I guess this solution will solve my problem. I am using InAppWebView to render HTML string with initialData. So I set null initialRequest property. It is working on android, but iOS is not rendering.

@RodXander
Copy link
Contributor Author

Add this in pubspec.yaml
flutter_inappwebview: git: https://github.com/RodXander/flutter_inappwebview.git

It tells flutter to load the plugin from a git repository. Said repository is a fork I made of this one where the change is implemented, I regularly check on this one, as soon as the author starts accepting new pull requests you just revert to the normal way of adding the plugin.

@myagizguler
Copy link

@RodXander thanks for the quick reply. It doesn't work again. I guess I have an error that is not related to this. Thanks.

@pichillilorenzo pichillilorenzo changed the base branch from master to develop April 16, 2022 09:28
@pichillilorenzo pichillilorenzo merged commit a34ea80 into pichillilorenzo:develop Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants