Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make #-style comments configurable - Default to True #346

Merged
merged 4 commits into from
Jun 3, 2016
Merged

Make #-style comments configurable - Default to True #346

merged 4 commits into from
Jun 3, 2016

Conversation

ocsurfnut
Copy link

@ocsurfnut ocsurfnut commented May 16, 2016

A simple change to allow us to turn off comments in output if needed.

@dirkrombauts
Copy link
Member

I didn't look at the code yet, so only two quick comments:

  1. Please name the parameter "enableComments". The default value of true is good.
  2. It's good practice to rebase your develop branch from the picklesdoc develop branch and to then create a feature branch for your work. That will eliminate most of the weird history issues.

@dirkrombauts
Copy link
Member

And of course: thank you for your continuing contributions!

@ocsurfnut
Copy link
Author

@dirkrombauts , changed command-line arg to --enableComments. Also rebased and got rid of weird history, thanks!

@dirkrombauts
Copy link
Member

Glad you got the history sorted out!

I'm taking a training tomorrow, so I probably won't get around to reviewing your PR in detail until Wednesday (central european summer time).

@ocsurfnut ocsurfnut changed the title Add --comments Flag to Command Line - Default to True Add --enableComments Flag to Command Line - Default to True May 18, 2016
@dirkrombauts
Copy link
Member

Looks good so far. Would you please also add the option to the three other runners? Thanks!

@ocsurfnut
Copy link
Author

Just pushed additions to other runners @dirkrombauts

@dirkrombauts
Copy link
Member

Thanks, I will review it later today (or tomorrow)!

@dirkrombauts
Copy link
Member

@ocsurfnut thanks for your work. The msbuild and powershell runners look good.

There's a slight problem with the UI runner, though.

When I open the UI, set "Enable Comments" to off, close the UI and open the UI again, then I expect the "Enable Comments" switch to be off. It is turned on.

Could you please look into that? Thanks!

@ocsurfnut
Copy link
Author

@dirkrombauts , good catch, was setting the backing field enableComments instead of using the EnableComments property, so the PropertyChanged notification wasn't getting fired. Fixed now.

@dirkrombauts dirkrombauts merged commit 094820d into picklesdoc:develop Jun 3, 2016
@dirkrombauts
Copy link
Member

Thanks! I plan to release this next week - so there's time if you have some more contributions ;-)

@ocsurfnut
Copy link
Author

Thanks @dirkrombauts! This is the only other one I'd like to get into the release if possible: #350

@dirkrombauts dirkrombauts changed the title Add --enableComments Flag to Command Line - Default to True Make #-style comments configurable - Default to True Jun 13, 2016
@dirkrombauts dirkrombauts mentioned this pull request Jun 14, 2016
dirkrombauts added a commit that referenced this pull request Jun 14, 2016
* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0
@dirkrombauts
Copy link
Member

Released in version 2.7.0

dirkrombauts added a commit that referenced this pull request Jun 29, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Edit release notes

* Version Bump (2.8.0)
dirkrombauts added a commit that referenced this pull request Jun 29, 2016
* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)
dirkrombauts added a commit that referenced this pull request Sep 28, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3
dirkrombauts added a commit that referenced this pull request Oct 7, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Release 2.8.3 (#376)

* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Version Bump (2.9.0)
dirkrombauts added a commit that referenced this pull request Oct 7, 2016
* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Release 2.8.3 (#377)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Special chars need to be replaced (#375)

* Special chars need to be replaced

There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull.

* Special chars need to be replaced #375
Creating test cases and fixing handling of umlauts and ampersand

* Changed indentation

* Fix Importing Test Results failure for MsTest (#378)

* + fix null featureTreeNode in ApplyTestResultsToFeature
+ handle null value for GetExampleResults and defaulted to TestResult.Inconclusive

* + added extra test scenario for MsTest with ignored ScenarioOutline examples

* + refactored LINQ for FeatureNode in ApplyTestResultsToFeatures

* Show parser failures and quit with an error (#379)

* Don't swallow exceptions if parsing a feature file throws. If parsing fails we want the build to break. We don't want to silently ignore parts.

* Improve NLog layout for console
- Don't show datetime, loglevel and logger
- Use colors
- Show exception messages

* Version Bump (2.9.0)
dirkrombauts added a commit that referenced this pull request Oct 7, 2016
* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Release 2.7.0 (#351)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* Release 2.8.0 (#355)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Release 2.6.3 (#348)

* Version Bump

* Update change log

* Add --enableComments Flag to Command Line - Default to True (#346)

* Command-Line Flag --comments - Default to True - Incl Unit Test

* Changed Command Line Argument --comments to --enableComments

* Added Enable Comments Option to MSBuild - Powershell - WPF Runners

* Fixed Bug with enableComments Property Not Being Used in MainViewModel

* Release 2.7.0 (#352)

* Release 2.6.3 (#347)

* Enhancement to support Unix path! (#344)

I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine.

However without this little change we can't get the folder structure display correctly.

Could you integrate this modification?

Thanks

* Version Bump

* Update change log

* Add EnableComments to the targets file

* Adapt change log

* Version bump to 2.7.0

* #320 - Scenario Deep Linking - DHTML and HTML Output (#350)

* #320 - Scenario Deep Linking - DHTML and HTML Output

* #320 - Fix Failing Unit Tests

* #320 - Resolved Issue with Image Resource Not Copying

* #320 - Add Backward-Compatibility for Hashed Feature Path

* #320 - Added Modal Dialog for Link Copy

* Edit release notes

* Version Bump (2.8.0)

* Release 2.8.1 (#360)

* Release 2.8.3 (#376)

* Delete CNAME as advised by github support

* Create CNAME

* Get rid of ngenerics (#370)

* Use Tree instead of NGenerics.GeneralTree

* Use visitor instead of ActionVisitor

* Rename Visitor to Traversor

* Remove reference to unused NGenerics library

* Fix whitespace

* Remove NGenerics from nuspecs and build scripts

* Get rid of traversor

* Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369)

* Compatibility with nunit.console 3.4 and nunit.framework 2.6

* Added example output file and test for nunit 2 tests ran with nunit 3 runner.

* Add "NUnit 2 tests run by NUnit 3" to test harness (#371)

* Move generation and commit of output to DeployArtifacts (#372)

* Added test for sorting when generating word docs (#373)

* Added test for sorting when generating word docs

* Use stream overloads of WordprocessingDocument

* Improve tree (#374)

* Add test about sorting

* Make it compile

* Make it pass

* Check for null in constructor

* Add test about null names in iteration

* Factory method for creating trees

* Check for null tree when adding

* Add test for null node

* Add release notes

* Fix some markdown syntax things

* Bump version number (2.8.3)

* Version 2.8.3

* Version Bump (2.9.0)

* Version 2.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants