Make #-style comments configurable - Default to True #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't look at the code yet, so only two quick comments:
|
|
And of course: thank you for your continuing contributions! |
|
@dirkrombauts , changed command-line arg to |
|
Glad you got the history sorted out! I'm taking a training tomorrow, so I probably won't get around to reviewing your PR in detail until Wednesday (central european summer time). |
ocsurfnut
changed the title
|
Looks good so far. Would you please also add the option to the three other runners? Thanks! |
|
Just pushed additions to other runners @dirkrombauts |
|
Thanks, I will review it later today (or tomorrow)! |
|
@ocsurfnut thanks for your work. The msbuild and powershell runners look good. There's a slight problem with the UI runner, though. When I open the UI, set "Enable Comments" to off, close the UI and open the UI again, then I expect the "Enable Comments" switch to be off. It is turned on. Could you please look into that? Thanks! |
|
@dirkrombauts , good catch, was setting the backing field |
|
Thanks! I plan to release this next week - so there's time if you have some more contributions ;-) |
|
Thanks @dirkrombauts! This is the only other one I'd like to get into the release if possible: #350 |
dirkrombauts
changed the title
Merged
dirkrombauts
added a commit
that referenced
this pull request
Jun 14, 2016
* Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0
|
Released in version 2.7.0 |
dirkrombauts
added a commit
that referenced
this pull request
Jun 29, 2016
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Edit release notes * Version Bump (2.8.0)
dirkrombauts
added a commit
that referenced
this pull request
Jun 29, 2016
* Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0)
dirkrombauts
added a commit
that referenced
this pull request
Sep 28, 2016
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3
dirkrombauts
added a commit
that referenced
this pull request
Oct 7, 2016
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Release 2.8.3 (#376) * Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Version Bump (2.9.0)
dirkrombauts
added a commit
that referenced
this pull request
Oct 7, 2016
* Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Release 2.8.3 (#377) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Special chars need to be replaced (#375) * Special chars need to be replaced There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull. * Special chars need to be replaced #375 Creating test cases and fixing handling of umlauts and ampersand * Changed indentation * Fix Importing Test Results failure for MsTest (#378) * + fix null featureTreeNode in ApplyTestResultsToFeature + handle null value for GetExampleResults and defaulted to TestResult.Inconclusive * + added extra test scenario for MsTest with ignored ScenarioOutline examples * + refactored LINQ for FeatureNode in ApplyTestResultsToFeatures * Show parser failures and quit with an error (#379) * Don't swallow exceptions if parsing a feature file throws. If parsing fails we want the build to break. We don't want to silently ignore parts. * Improve NLog layout for console - Don't show datetime, loglevel and logger - Use colors - Show exception messages * Version Bump (2.9.0)
dirkrombauts
added a commit
that referenced
this pull request
Oct 7, 2016
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Release 2.8.3 (#376) * Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Version Bump (2.9.0) * Version 2.9.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple change to allow us to turn off comments in output if needed.