-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with nunit.console 3.x and nunit.framework 2.x #369
Compatibility with nunit.console 3.x and nunit.framework 2.x #369
Conversation
Thanks. The code looks good. However, I am following a test-first policy on Pickles, so in order for me to merge this pull request, there need to be some unit tests. Do you think you could add those? |
I added a test output matching nunit 2 tests ran with nunit 3 runner. (Tbh. I copied the nunit 3 output and renamed the description attribute names) |
Thanks for the addition, i'll look into it tomorrow. If it checks out, I'll do a release next week. |
Great. On another note, it'd be nice to be able to plug in new generators. For instance feature and scenario names only to Excel. Is that something you'd pull if I can sew it together? Vennlig hilsen Lars-Erik Aabech From: Dirk Rombautsmailto:notifications@github.com Thanks for the addition, i'll look into it tomorrow. If it checks out, I'll do a release next week. — |
Yes, I am in favour of a plugin-like system for output formats (as long as it is test-driven ;-) ). This ties in nicely with something else I would like to do: move the output generators to their own project(s). One of the goals there is to make it easier to separate the .NET core-compatible output generators from those that aren't. Would you be interested in doing this refactoring as a prelude to your idea? |
I'll give it a shot. Got quite a few balls in the air, so having difficulty committing, but pickles is one of my new favorite softwares, so it's high up in my todo stack. ;) |
* Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3
Released in version 2.8.3 |
\o/ |
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Release 2.8.3 (#376) * Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Version Bump (2.9.0)
* Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Release 2.8.3 (#377) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Special chars need to be replaced (#375) * Special chars need to be replaced There are some more special chars (especially german Umlaute) that need to be replaced for the match to be successfull. * Special chars need to be replaced #375 Creating test cases and fixing handling of umlauts and ampersand * Changed indentation * Fix Importing Test Results failure for MsTest (#378) * + fix null featureTreeNode in ApplyTestResultsToFeature + handle null value for GetExampleResults and defaulted to TestResult.Inconclusive * + added extra test scenario for MsTest with ignored ScenarioOutline examples * + refactored LINQ for FeatureNode in ApplyTestResultsToFeatures * Show parser failures and quit with an error (#379) * Don't swallow exceptions if parsing a feature file throws. If parsing fails we want the build to break. We don't want to silently ignore parts. * Improve NLog layout for console - Don't show datetime, loglevel and logger - Use colors - Show exception messages * Version Bump (2.9.0)
* Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Release 2.7.0 (#351) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * Release 2.8.0 (#355) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Release 2.6.3 (#348) * Version Bump * Update change log * Add --enableComments Flag to Command Line - Default to True (#346) * Command-Line Flag --comments - Default to True - Incl Unit Test * Changed Command Line Argument --comments to --enableComments * Added Enable Comments Option to MSBuild - Powershell - WPF Runners * Fixed Bug with enableComments Property Not Being Used in MainViewModel * Release 2.7.0 (#352) * Release 2.6.3 (#347) * Enhancement to support Unix path! (#344) I'm not sure you already got a try or a feedback about it but actually pickles run relatively well under Linux with mono which is interesting when like me you can't get a windows machine. However without this little change we can't get the folder structure display correctly. Could you integrate this modification? Thanks * Version Bump * Update change log * Add EnableComments to the targets file * Adapt change log * Version bump to 2.7.0 * #320 - Scenario Deep Linking - DHTML and HTML Output (#350) * #320 - Scenario Deep Linking - DHTML and HTML Output * #320 - Fix Failing Unit Tests * #320 - Resolved Issue with Image Resource Not Copying * #320 - Add Backward-Compatibility for Hashed Feature Path * #320 - Added Modal Dialog for Link Copy * Edit release notes * Version Bump (2.8.0) * Release 2.8.1 (#360) * Release 2.8.3 (#376) * Delete CNAME as advised by github support * Create CNAME * Get rid of ngenerics (#370) * Use Tree instead of NGenerics.GeneralTree * Use visitor instead of ActionVisitor * Rename Visitor to Traversor * Remove reference to unused NGenerics library * Fix whitespace * Remove NGenerics from nuspecs and build scripts * Get rid of traversor * Compatibility with nunit.console 3.4 and nunit.framework 2.6 (#369) * Compatibility with nunit.console 3.4 and nunit.framework 2.6 * Added example output file and test for nunit 2 tests ran with nunit 3 runner. * Add "NUnit 2 tests run by NUnit 3" to test harness (#371) * Move generation and commit of output to DeployArtifacts (#372) * Added test for sorting when generating word docs (#373) * Added test for sorting when generating word docs * Use stream overloads of WordprocessingDocument * Improve tree (#374) * Add test about sorting * Make it compile * Make it pass * Check for null in constructor * Add test about null names in iteration * Factory method for creating trees * Check for null tree when adding * Add test for null node * Add release notes * Fix some markdown syntax things * Bump version number (2.8.3) * Version 2.8.3 * Version Bump (2.9.0) * Version 2.9.0
No description provided.