Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features don't render correctly when there are less than 4 spaces #106

Merged
merged 1 commit into from
May 7, 2014

Conversation

seanfitzg
Copy link

When a feature does not have 4 spaces at the start of a line, it does
not render correctly with the code tags.

When a feature does not have 4 spaces at the start of a line, it does
not render correctly with the <code></code> tags.
@seanfitzg seanfitzg changed the title Fix for feature not rendering correctly Features don't render correctly when there are less than 4 spaces May 2, 2014
@seanfitzg seanfitzg closed this May 2, 2014
@seanfitzg seanfitzg reopened this May 2, 2014
dirkrombauts added a commit that referenced this pull request May 7, 2014
Features don't render correctly when there are less than 4 spaces
@dirkrombauts dirkrombauts merged commit fc8c8f7 into picklesdoc:master May 7, 2014
@dirkrombauts
Copy link
Member

Thanks!

@dirkrombauts
Copy link
Member

This seems to have unintended consequences - see https://groups.google.com/forum/#!topic/pickles-dev/hohI2bZqqKA

@seanfitzg
Copy link
Author

I guess it could an unintended consequence, or could it be considered more consistent behaviour?

Previously, feature and scenario descriptions only appeared in Code blocks when they started with 4 spaces. However, this meant that in same cases they displayed as a code block, and in other cases, they didn't. It was up to the developer if they remembered the spaces. So in our case, we had descriptions rendered in a mix of code and non-code. Happy to revert it if you want!

@dirkrombauts
Copy link
Member

The scenario and feature descriptions are meant to render as markdown - you're actually the first person to tell me that they prefer the code block version.

So I'd prefer you to revert the change, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants