Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where multiple results files for a single feature causes exceptions when processing scenario outline examples. #123

Merged

Conversation

photomoose
Copy link

A bit of an edge case here, but hey, this is how I'm using it!

I run NUnit with two passes. The first pass only runs tests from a "work in progress" category - this test run does not fail the build if any test fails. The second pass runs tests from all categories except for those that were run in the first pass - this test run does fail the build if any test fails. The two passes generate two NUnit results files for a single SpecFlow feature file.

When running Pickles against a single feature, but with two NUnit results files, I noticed that an exception was thrown when trying to parse test examples from Scenario Outlines.

The following commit should fix this problem. Try running the unit test without the changes in NUnitSingleResults.cs - the test should fail. Apply my changes and the test should pass.

…exceptions when processing scenario outline examples.
@photomoose photomoose changed the title Fixed issue where multiple results files for a single feature caused exceptions when processing scenario outline examples. Fixed issue where multiple results files for a single feature causes exceptions when processing scenario outline examples. Jun 9, 2014
dirkrombauts added a commit that referenced this pull request Jun 10, 2014
…iles

Fixed issue where multiple results files for a single feature causes exceptions when processing scenario outline examples.
@dirkrombauts dirkrombauts merged commit d746f05 into picklesdoc:master Jun 10, 2014
@dirkrombauts
Copy link
Member

Thanks. BTW: you don't need to close a github pull request and open a new one: you can update existing pull requests.

@photomoose photomoose deleted the SingleFeature-MultipleResultFiles branch June 10, 2014 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants