-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue with Scenario Outline Data Containing Parenthesis #299
Fix Issue with Scenario Outline Data Containing Parenthesis #299
Conversation
Thanks for this contribution. I try to follow a strict test-first policy for new contributions to the .NET code, so I would like to ask you to provide unit tests as well. I added a new section to the CONTRIBUTING.md file to describe what I expect. If you have any questions after reading it, please ask me and I will try to explain more clearly. |
I've included the new test results from pickles-testresults (see PR picklesdoc/pickles-testresults#14) as well as the unit tests and implementation to make them pass. Hopefully this makes the PR more complete. |
This is exactly the way I wanted it! Two more additions will make it perfect:
If you have merge issues with the test result files: overwrite them with your version :-) |
|
Thanks - it's bedtime in my time zone so I will look into this tomorrow. Based on our collaboration so far I think it will be fine, and I'll release a new version of Pickles in time for your next work day :-) |
Fix Issue with Scenario Outline Data Containing Parenthesis
Many thanks! |
Released in v2.4.1. |
We found an issue when the scenario outline examples included
()
characters the Regex match did not work correctly, and the scenario was flagged as inconclusive. Adding some\
escaping fixed the issue.