Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error handling for Markdown parsing exceptions #497

Merged

Conversation

joebuschmann
Copy link

The StrikeMarkdownProvider throws an exception when parsing lines like
below. I added error handling to note the exception in the report and
keep processing. The MarkdownProvider class doesn't have the same issue.
It escapes the value properly.

Markdown:

  • 1911 Changing misleading comment that implies that every
    ICollection is a list

The StrikeMarkdownProvider throws an exception when parsing lines like
below. I added error handling to note the exception in the report and
keep processing. The MarkdownProvider class doesn't have the same issue.
It escapes the <T> value properly.

Markdown:

* 1911 Changing misleading comment that implies that every
ICollection<T> is a list
@dirkrombauts dirkrombauts merged commit 290f58c into picklesdoc:develop Nov 5, 2017
@dirkrombauts
Copy link
Member

Thank you for your contribution!

@joebuschmann joebuschmann deleted the handle-markdown-exception branch November 6, 2017 14:18
@dirkrombauts dirkrombauts changed the title Error handling for Markdown parsing exceptions Added error handling for Markdown parsing exceptions Nov 6, 2017
@dirkrombauts dirkrombauts mentioned this pull request Nov 6, 2017
@dirkrombauts
Copy link
Member

Released in version 2.17.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants