Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JSONDocumentationBuilder performance #504

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

tlecomte
Copy link

@tlecomte tlecomte commented Jan 29, 2018

Improve JSONDocumentationBuilder performance by preparing lookups instead of using Where repeatedly.

This has been tested on a solution with 6000 test scenarios, with the following options:
Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx

Before: 5.3 seconds
After: 4.3 seconds

Unit tests pass.
The resulting json files are identical (except "GeneratedOn" datetime).

Improve JSONDocumentationBuilder performance by preparing lookups instead of using Where repeatedly.

This has been tested a solution with 6000 test scenarios, with the following options:
Pickles.exe -f xxx -o xxx --trfmt=nunit3 --enableComments=false -df=json -lr=xxx

Before: 5.3 seconds
After: 4.3 seconds

Unit tests pass.
The resulting json files are identical (except "GeneratedOn" datetime).
@tlecomte
Copy link
Author

This is another PR for performance related to lookups. I have a few other changes with higher impact on the timing, but this one is on the same topic as #503 so I figured I would send it first.

Thanks for considering this PR!

@dirkrombauts dirkrombauts merged commit 1c160f2 into picklesdoc:develop Jan 29, 2018
@dirkrombauts
Copy link
Member

Thanks again!

@dirkrombauts
Copy link
Member

Released in version 2.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants