-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario Outline special characters workaround #509
Conversation
I may have mentioned in another pull request that my regex skills are rusty :-) What problem does this pull request solve? Could you perhaps create a unit tests that shows the problem? |
Isn't this pull request very similar to #506 ? You closed #506, probably because you said "source tree did something really strange during the merge". I stand by the comment I made in #506 : If there is a bug, I want a unit test that shows the bug is solved. If you need assistance in creating a good unit test, please let me know. |
Additionally the list of the "example" attributes is there : (example: 1). So what I try to do is:
This change should be totally transparent for the old functionality and gives only additional try if it's not possible to match original name. I will need some your support with unit tests because for next few days/maybe even weeks i definitely wont have time work on anything. Here you could find some more information and my founds about unit tests for that issue: #508 hope it helps to understand - I am not the best with explanation of the technical aspects in the real language sorry. |
@dirkrombauts : Hi Dirk. do you think you could help me with these unit tests ? Unfortunately I do not have any chance to update it in the reasonable time :( |
Hi @DominikBaran I want to help you but I'm more or less in the same situation - I don't have the opportunity to invest a lot of time in this. I'm chipping away at it, an hour here, half an hour there. Progress is slow. |
@dirkrombauts : understand. that's all good - if you will be able to submit some code in the future it would be awesome. if not i will also try organize some time and add unit tests (but it could be even 2nd half of the year). |
@DominikBaran could you please check whether this problem still exists in version 2.18.1? There are some big changes to the name matching in the new version. |
hello @dirkrombauts : unfortunately still the same issue: |
@dirkrombauts : I have also one observation after update my Xunit from 2.1.0 to 2.3.0/2.3.1 Will try to investigate that problem - and also create new "Issue" for that |
@dirkrombauts : I also added small fix for Xunit 2.1.0 and 2.3.x issue. For the matcher I remove \ if this kind of encoding exists That should be fix for: |
…develop # Conflicts: # src/Pickles/Pickles.TestFrameworks/XUnit/XUnit2/XUnit2ScenarioOutlineExampleMatcher.cs
…d the expression use Regexp.IgnoreCase instead to LowerInvariant method
I'll be on holiday until end of May, so I won't be able to continue on this until then. |
Thank you for your contribution (and your patience) |
Hi Dirk, I wonder if this also solves the following cases im facing: Examples:
It wont properly handle @ signs. |
Hi @MichielBerkhof, Good question - could you compile the latest version and test it? I will try to create a new release next week before I leave on holiday. |
Hi @dirkrombauts, Ive cloned the repo, built the dev branch, and executed the pickles.exe against the scenario's. This resulted in the following outcome: I can see the @ signs in the examples, but the was executed and wassuccesfull both return false. Which makes me think it doesnt work yet? Please let me know if i read this correctly To add to this, i did the same on the master branch, same result |
Hi @dirkrombauts, Did you get a chance to look into these issues? |
No, I'm sorry. I'm rather limited with my time. It would be helpful if you could provide me with .trx and .feature files - maybe I will be able to squeeze in some debugging time next week. Trying to get a release out of the door has priority though. There's some features that are waiting to see the official light of day. |
Hi @dirkrombauts, Above ZIP contains our CreateUser scenario with the trx results generated by TeamCity. In these examples you can see the scenario: Can't create user with invalid email address In the trx, they all pass, but pickles wont see them as passed. I hope you could squeeze in just a little extra effort, would be much appreciated by our PO ;) |
The reality of an open source project is that the fastest way to get something done is to fix it yourself and then send a pull request :-) Cheers, |
Released in version 2.19.0 |
@MichielBerkhof I created a new issue to track the problems with @ signs and such that you reported on 11 July. |
Thanks dirk, ill try to find some spare time at work to take a more detailed look into it, but cant promise i can find the time. Its kinda busy... |
@dirkrombauts