Fix example matching for VSTest #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvandertil
force-pushed
the
fix-vstest-naming
branch
3 times, most recently
from
06d2d93
to
854ef80
Compare
|
ping @dirkrombauts, did you have a chance to look at this? |
|
Not yet - as it happens, I have some time site aside for Pickles today :-) |
|
Hi, Thanks for your contribution. It looks good. However, due to some other pull requests, your code is now behind picklesdoc/develop. Please merge those changes into your feature branch. As soon as you do that, I'll merge your pull request. |
Implements the VsTestScenarioOutlineExampleMatcher to detect _Variant style examples. These occur when there are examples which contain characters that are illegal for method names, or when examples contain duplicate values in the first column. Fixes picklesdoc#507
jvandertil
force-pushed
the
fix-vstest-naming
branch
from
854ef80
to
33bb2c7
Compare
|
I rebased my branch on top of develop. Should be ready to merge. |
|
Bedankt! |
Merged
|
Released in version 2.19.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the VSTestScenarioOutlineExampleMatcher to detect example tests that are generated with the _Variant# naming style.
This naming style is used when examples contain characters that are illegal in method names in C#, or when the first column of the examples contains duplicate values.
Also fixes an issue with building Pickles on a clean checkout, a package reference was missing for SpecFlow.
This fixes issue #507.
Possible issues with this PR: I have added the examples to the ScenarioOutline in the StandardTestSuite as this is the only way (I know of) to match the examples back to the test results. I've tested this with a couple of SpecFlow feature files and the examples are filled then, just not when running the unit tests.