Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICO v.9 #223

Closed
johnnywon opened this issue May 11, 2015 · 5 comments
Closed

PICO v.9 #223

johnnywon opened this issue May 11, 2015 · 5 comments

Comments

@johnnywon
Copy link

This update is broken.

It will not run, you require /vendor and it's not even included in the repository. Please update immediately, for all other users please use v.8 which works normally.

@theshka
Copy link
Collaborator

theshka commented May 11, 2015

Please see issues #121, #211, #216. You need to run the composer install. Instructions are available in the README.

@johnnywon
Copy link
Author

I don't see why we have to run composer install when the previous update worked without it. You've created an extra and unnecessary step.

@theshka
Copy link
Collaborator

theshka commented May 11, 2015

Because it is good practice to keep the vendor directory out of git.
This update was committed before I started collaborating on the project.

@theshka theshka closed this as completed May 11, 2015
@johnnywon
Copy link
Author

If it is "good practice of keeping the vendor director out of git" and "Pico is a stupidly simple, blazing fast, flat file CMS." then why would you intentionally make this harder? This means I can't ask my clients to just download the zip and run it on their web server, they need SSH and install something they're not familiar with. This is a significant problem to real people.

@dav-m85
Copy link
Contributor

dav-m85 commented Aug 19, 2015

I suggest providing an already "composer installed" package build for those use cases.

@theshka 👍 Like this change, vendor was a pain.
@johnnywon Sme reading on why it is a bad idea of having vendor tied to your local subversion tree: https://getcomposer.org/doc/faqs/should-i-commit-the-dependencies-in-my-vendor-directory.md

@PhrozenByte PhrozenByte mentioned this issue Aug 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants