-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Aria compliant breadcrumb component #157
Conversation
Closes #144 |
@jelmerveen, aria-label="breadcrumb"Nice find. You're right The example in the accessible breadcrumb pattern referenced on the w3c page however uses lower case 🤔. I'd instead use the lowercase version if you're ok with it. !importantWe can avoid a::after {
- color: var(--muted-color) !important;
+ color: var(--muted-color);
}
a[aria-current="page"] {
- color: inherit !important;
+ color: inherit;
} RTL (right-to-left)Using ul li {
- padding-left: 0;
+ padding-inline-start: 0;
&:not(:last-child) {
a::after {
- padding-left: 0.5rem;
+ padding-inline-start: 0.5rem;
}
}
} Let me know if you want to make the changes. |
@lucaslarroche thanks for the great feedback! I have made the changes, and updated with the dev branch, since it was already a long time. Else please feel free to update it accordingly! |
Hi @jelmerveen, I rebased the branch, rebuild the CSS, and changed the style of code snippets. I will merge into dev, and then in the next release quickly. |
Implemented now with feedback and according to the aria specification:
https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html