Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually choose partitions #73

Closed
wants to merge 11 commits into from
Closed

Conversation

gazorby
Copy link

@gazorby gazorby commented Mar 6, 2020

A small rework of partitioning part to allow installing without clearing partition table

Four new global variables are introduced :

ERASE="false"  # If true, partitions will be automatically created

PARTITION_BIOS=""  # let this empty if you have an EFI system
PARTITION_BOOT=""
PARTITION_ROOT="" 

When setting ERASE to false, DEVICE variable is ignored, otherwise, PARTITION_BIOS, PARTITION_BOOT and PARTITION_ROOT are ignored.

check_variables() has also been updated to ensure PARTITION_BIOS is correctly set on BIOS system.

Moreover, i upadated encrypt options to use aes-xts-plain64 cipher (based on cryptsetup benchmark) and --align-payload=8192 option (based on this explanation)

@picodotdev
Copy link
Owner

picodotdev commented Mar 8, 2020

Hi Gazorby, I created #76 to allow custom partition to be based on your pull request, that I think will allow to delegate to alis the creation of the partitions (with a option manual to only use existing partitions, this would be the case of your PR, the options custom will allow to avoid clear the partition table) but at the same time use a custom partition scheme. This is for avoid to be the user to do manually and before alis execution the partition.

For the other changes, this is info that gives my system that I created without specifying -c aes-xts-plain64. The value xts-plain64 is different than aes-xts-plain64?.

sudo cryptsetup luksDump /dev/nvme0n1p2 |grep -e "mode" -e "Payload" -e "MK bits"
[sudo] password for picodotdev: 
Cipher mode:   	xts-plain64
Payload offset:	4096
MK bits:       	512

For --align-payload=8192 I dont know if this is also different from default values, the explanation link dates from 2010, I dont know if this has changed from then.

Is there in the Arch Linux wiki about this?
Also I dont know if this is done automatic as the following comment.

(cryptsetup will get support for automatic alignment according
to kernel exported device parameters soon, so all this will be automatic)

picodotdev added a commit that referenced this pull request Mar 9, 2020
* Set keyboard layout
* Support custom kernel parameters
* Support F2FS

Fixes #73
Fixes #75
Fixes #76
Fixex #77
@picodotdev
Copy link
Owner

picodotdev commented Mar 9, 2020

I uploaded a branch with a initial implementation for this, I dont tested yet.

-c aes-xts-plain64 and --align-payload=8192 yet no.

@picodotdev picodotdev closed this in 1a939a2 Mar 9, 2020
@picodotdev
Copy link
Owner

-c aes-xts-plain64 and --align-payload=8192 yet no implemented, I am not completely sure they are necessary and good recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants