Adjust CODE_128 to handle odd number of digits #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2017 16:28
This is a change so that handling for CODE_128 auto takes into account an odd number of digits after an initial string. This then works for international DPD shipping integration "NOTE: If the postcode is all numeric, use subset B for the first 2 digits of the data string, e.g. %0, followed by subset C for the rest of the barcode." Example %008099915501071048275101276 Previously this would output * SUBSET B = %, length 1 * SUBSET C = 00809991550107104827510127, length 26 * SUBSET B = 6, length 1 Now expected outcome is * SUBSET B = %0, length 2 * SUBSET C = 08099915501071048275101276, length 26
formatting
|
This is to avoid two mode shifts for Barcode length optimization This is the Wiki entry on how I understand this to work - https://en.wikipedia.org/wiki/Code_128#Barcode_length_optimization |
|
Bump :D |
|
Thanks @rlweb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change so that handling for CODE_128 auto takes into account an odd number of digits after an initial string. This then works for international DPD shipping integration "NOTE: If the postcode is all numeric, use subset B for the first 2 digits of the data
string, e.g. %0, followed by subset C for the rest of the barcode."
Example %008099915501071048275101276
Previously this would output
Now expected outcome is