Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request PID for LNE projects #517

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Request PID for LNE projects #517

merged 3 commits into from
Oct 26, 2020

Conversation

NWIron
Copy link
Contributor

@NWIron NWIron commented May 6, 2020

  • Add a 'LNE' organization

  • Request PID 5858 for LNE Keyboard Device

@tannewt tannewt mentioned this pull request Sep 15, 2020
50 tasks
@tannewt
Copy link
Collaborator

tannewt commented Sep 16, 2020

Where are your hardware files?

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing hardware files.

@NWIron
Copy link
Contributor Author

NWIron commented Oct 20, 2020

Hi, please check the following link:
https://github.com/NWIron/qmk_firmware/tree/master/keyboards/unidock

@tannewt
Copy link
Collaborator

tannewt commented Oct 20, 2020

Please provide native CAD files that are user modifiable. Images of the schematic aren't considered open source by us.

@NWIron
Copy link
Contributor Author

NWIron commented Oct 20, 2020

Please check again, I have uploaded the pcb files.

@tannewt
Copy link
Collaborator

tannewt commented Oct 21, 2020

@NWIron Please include a LICENSE file in the repo as well.

@NWIron
Copy link
Contributor Author

NWIron commented Oct 21, 2020

I moved the source codes & assets to a new repo https://github.com/NWIron/unidock.

@NWIron NWIron requested a review from tannewt October 21, 2020 06:34
owner: LNE
license: GPLv3
site: https://github.com/ln-org
source: https://github.com/NWIron/qmk_firmware
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to the new repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you time, I have updated the source link!

@NWIron NWIron requested a review from tannewt October 26, 2020 01:02
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tannewt tannewt merged commit 4b60bcc into pidcodes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants