Pre-populate a 0 amount for all invoice payment lines #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sweep-ai[bot]](https://avatars.githubusercontent.com/in/307814?s=60&v=4){kind=small}
|
Add a new test case. |
pierre
requested changes
Aug 3, 2023
test/integration/navigation_test.rb
Outdated
| test 'test_payment_amount_field_behavior' do | ||
| # Create mock invoices and mock payments | ||
| mock_invoices = [Invoice.new(balance: 0), Invoice.new(balance: 10)] | ||
| mock_payments = [Payment.new(amount: 0), Payment.new(amount: 10)] |
There was a problem hiding this comment.
There should be a single mock payment
test/integration/navigation_test.rb
Outdated
| mock_payments = [Payment.new(amount: 0), Payment.new(amount: 10)] | ||
|
|
||
| # Simulate a GET request to the deposit page | ||
| get '/deposit' |
test/integration/navigation_test.rb
Outdated
|
|
||
| test 'test_payment_amount_field_behavior' do | ||
| # Create mock invoices and mock payments | ||
| mock_invoices = [Invoice.new(balance: 0), Invoice.new(balance: 10)] |
There was a problem hiding this comment.
These need to be loaded via AJAX, by calling the account_invoices route.
pierre
reviewed
Aug 3, 2023
| @@ -44,7 +44,8 @@ $(document).ready(function() { | |||
| } | |||
| ], | |||
| createdRow: function(row, data, dataIndex) { | |||
| $('td', row).eq(4).html('<input class="payment_amount_invoice" type="number" name="payment_amount_' + data[0] + '" id="payment_amount_' + dataIndex + '" step="any" class="form-control">') | |||
| var disabled = data[3] == 0 ? ' disabled' : ''; | |||
There was a problem hiding this comment.
data[3] is the amount with the currency. Remove all non-numeric characters before comparing it to 0.
pierre
reviewed
Aug 3, 2023
| @@ -44,7 +44,8 @@ $(document).ready(function() { | |||
| } | |||
| ], | |||
| createdRow: function(row, data, dataIndex) { | |||
| $('td', row).eq(4).html('<input class="payment_amount_invoice" type="number" name="payment_amount_' + data[0] + '" id="payment_amount_' + dataIndex + '" step="any" class="form-control">') | |||
| var disabled = parseFloat(data[3]) == 0 ? ' disabled' : ''; | |||
There was a problem hiding this comment.
parseFloat doesn't work that way. Use data[3].replace(/\D/g, '') instead.
pierre
reviewed
Aug 3, 2023
test/integration/navigation_test.rb
Outdated
|
|
||
| test 'test_payment_amount_field_behavior' do | ||
| # Simulate AJAX call to account_invoices route | ||
| get account_invoices_path, xhr: true |
There was a problem hiding this comment.
This won't work.
Remove this new test.
pierre
reviewed
Aug 3, 2023
test/integration/navigation_test.rb
Outdated
| @@ -9,4 +9,5 @@ class NavigationTest < ActionDispatch::IntegrationTest | |||
| get '/deposit' | |||
| assert_response :success | |||
| end | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue #1 by modifying the
_invoices_table.html.erbview. The changes include setting the default value of the payment amount input field to 0 and disabling it if the invoice balance is 0. Additionally, a new Rails view test is added to verify these changes using mock invoices and mock payments.Summary of Changes
app/views/deposit/collection/_invoices_table.html.erbto set the default value of the payment amount input field to 0 and disable it if the invoice balance is 0.test/integration/navigation_test.rbto verify the changes in the view. The test uses mock invoices and mock payments to check if the payment amount field is auto-populated with 0 and is disabled when the invoice balance is 0.Fixes #1.
To checkout this PR branch, run the following command in your terminal:
To make tweaks to this pull request, leave a comment below or in the code.