-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fold_handler
method signature
#6
Conversation
Corrects the `fold_handler` LSP handler signature to conform with a breaking NeoVim nightly update. This closes pierreglaser#5 by ensuring LSP results and buffer numbers are correctly gathered from arguments.
Thanks for the patch! Is there an easy way to remain backward-compatible with neovim versions preceding this change? |
Has enough time passed that we can switch to this despite it not being backwards-compatible? |
Hey @pierreglaser, I concur with @ElPiloto that we should merge this. |
It should be possible to detect the neovim version to do this. Not the best idea since feature detection is always more reliable than version detection, but that's the only way I can think of. |
I don't remember, really. I look at the diff and the made the change in my own fork: ajitid@71e46d2. Seems like the change results in completely skipping inner if condition. Unrelated, but another change I made is to only attach to those clients into which I've specified ajitid@6de3bb5. This reduces the nagging on upon opening each file. |
Ah, I agree, being able to specify which |
I'm closing this for now (see #6 (comment)), but feel free to re-open if I missed something. |
This reverts commit 71e46d2. ref the PR again, seems like it is not needed anymore
Corrects the
fold_handler
LSP handler signature to conform with abreaking NeoVim nightly update. This closes #5
by ensuring LSP results and buffer numbers are correctly gathered from
arguments.