Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fold_handler method signature #6

Closed
wants to merge 1 commit into from

Conversation

Nicholas-Hein
Copy link

Corrects the fold_handler LSP handler signature to conform with a
breaking NeoVim nightly update. This closes #5
by ensuring LSP results and buffer numbers are correctly gathered from
arguments.

Corrects the `fold_handler` LSP handler signature to conform with a
breaking NeoVim nightly update.  This closes pierreglaser#5
by ensuring LSP results and buffer numbers are correctly gathered from
arguments.
@pierreglaser
Copy link
Owner

Thanks for the patch! Is there an easy way to remain backward-compatible with neovim versions preceding this change?

@ElPiloto
Copy link

Has enough time passed that we can switch to this despite it not being backwards-compatible?

@ajitid
Copy link

ajitid commented Mar 4, 2023

Hey @pierreglaser, I concur with @ElPiloto that we should merge this.

@Lazerbeak12345
Copy link

Thanks for the patch! Is there an easy way to remain backward-compatible with neovim versions preceding this change?

It should be possible to detect the neovim version to do this. Not the best idea since feature detection is always more reliable than version detection, but that's the only way I can think of.

@pierreglaser
Copy link
Owner

@ElPiloto @ajitid wasn't this resolved by 5d2b3d9?

@ajitid
Copy link

ajitid commented Apr 10, 2023

I don't remember, really. I look at the diff and the made the change in my own fork: ajitid@71e46d2. Seems like the change results in completely skipping inner if condition.

Unrelated, but another change I made is to only attach to those clients into which I've specified ajitid@6de3bb5. This reduces the nagging on upon opening each file.

@pierreglaser
Copy link
Owner

Unrelated, but another change I made is to only attach to those clients into which I've specified ajitid@6de3bb5. This reduces the nagging on upon opening each file.

Ah, I agree, being able to specify which client folding-nvim should ask folds to would be nice to have. PR welcome!

@pierreglaser
Copy link
Owner

I'm closing this for now (see #6 (comment)), but feel free to re-open if I missed something.

ajitid added a commit to ajitid/folding-nvim that referenced this pull request Apr 10, 2023
This reverts commit 71e46d2.

ref the PR again, seems like it is not needed anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New LSP request callback signature incompatible
5 participants