Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation on linechart enter #7

Closed
wants to merge 2 commits into from
Closed

Animation on linechart enter #7

wants to merge 2 commits into from

Conversation

schirrel
Copy link

@schirrel schirrel commented Oct 1, 2018

in my old morris fork (moved to https://github.com/schirrel/morris.js) i had add someanimation online chart enter
alsoby that time i have made and formater for the value to show only inlegend, as far as i saw its similar to you hover callback, thus i dont think still interesting

great job done there pierre

Addingclassto attrs so it'll be animated with the new css
add aniomation from line charts and circle
pierresh pushed a commit that referenced this pull request Nov 6, 2018
Related to these discussion threads
morrisjs#507
#7
@pierresh
Copy link
Owner

pierresh commented Nov 6, 2018

Hi Alan,

thanks a lot for this pull request and sorry for my late reply. Your "in-line" animation is very interesting and definitively makes sense. Nevertheless, as it is mostly done of CSS (and therefore not really configurable), I suppose it is better to give flexibility, which CSS class has to be used per chart. That is why I just added new 2 options extraClassLine and extraClassCircle to define the extra class to be used.

@pierresh pierresh closed this Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants