Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broaden bulkAddEdges to accept Iterable<Pair<L, R>> #102

Closed
jgustie opened this issue Nov 3, 2016 · 2 comments
Closed

Broaden bulkAddEdges to accept Iterable<Pair<L, R>> #102

jgustie opened this issue Nov 3, 2016 · 2 comments
Labels
enhancement

Comments

@jgustie
Copy link
Contributor

jgustie commented Nov 3, 2016

The existing implementation of bulkAddEdges requires a List; from what I can see the list is used in a for-each loop and there is an empty test on it. It would be useful to pass in an arbitrary iterable to this method. Even a Collection would be ok (which keeps size() and isEmpty() available).
@pietermartin
Copy link
Owner

So Collection will do?

@jgustie
Copy link
Contributor Author

jgustie commented Nov 3, 2016

Yeah, Collection works and is way easier to implement.

pietermartin pushed a commit that referenced this issue Nov 5, 2016
add CHANGELOG for #102
5f3f9ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pietermartin @jgustie