Add support for array operators for postgres dialect #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add array operator support * Use array instead of list in ArrayContains and ArrayOverlaps predicates * Optimize Gremlin step with ArrayContains and ArrayOverlaps predicates * add tests * 1. Remove duplicate values while constructing ArrayContains and ArrayOverlaps predicates. 2. Use parameterized prepared statement for setting values instead of building query with them. * All tests to AllTest suite. Fix test * Add back accidentally deleted code * add support to deploy to tableau artifactory
|
@pietermartin could you please review this change and accept in mainline? This adds support for using array operators |
|
Thanks for the PR, looks good. I'll review it properly on the weekend. |
It is for easily publishing jars to a repository that my team uses internally. I can take it out and only keep in the fork that we maintain. Let me know. |
|
Yeah I think rather keep it in your local branch. Thanks |
added 2 commits
August 6, 2019 13:30
|
Done. Removed the tableau artifactory specific changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add array operator support
Optimize Gremlin step with ArrayContains and ArrayOverlaps predicates
Add tests