Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative way to click on words #36

Merged
merged 34 commits into from
Feb 23, 2021
Merged

Conversation

pietrop
Copy link
Owner

@pietrop pietrop commented Feb 6, 2021

Is your Pull Request request related to another issue in this repository ?

#30 #32

Describe what the PR does

looking to see if can avoid #30

State whether the PR is ready for review or whether it needs extra work

  • identifying word and make it clickable on double click by storing timing in Leaf words attribute next to text.
  • use decorator as a way to highlight words? <--- tbc how 🤷‍♂️
  • when running comparison, try and do it at paragraph level to avoid aligning the whole thing<-- Trying this next

Additional context

Pietro Passarelli added 4 commits February 6, 2021 02:48
can realign only paragraph who add a change, however if all the words were to be changed in paragraph, even with same numbeer of words, it seems to hang. Also had to disable edge cases around merging paragraphs, splitting paragraphs,and deleting across paragraphs. Can only delete within a single paragraph for now
Pietro Passarelli added 2 commits February 10, 2021 20:10
@pietrop pietrop mentioned this pull request Feb 18, 2021
Pietro Passarelli added 3 commits February 19, 2021 00:09
…eems to work most of the times, but worth doing some further testing
plus some clean up, preserved OHMS export, needs some more clean up
@pietrop pietrop mentioned this pull request Feb 23, 2021
@pietrop pietrop merged commit baee06f into master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant