Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Building happen async and in multiple process #53

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Made Building happen async and in multiple process #53

merged 4 commits into from
Jul 11, 2022

Conversation

beef331
Copy link
Contributor

@beef331 beef331 commented Apr 10, 2022

Prior to this on my machine building the docs for nimibook took roughly around 30s it now takes around 10s. For Norm's docs it went from around 60s down to around 30s. No clue if this is an overly interesting thing, just seen the easy ability to speed it up a bit so thought I wouldd make a PR

@pietroppeter
Copy link
Owner

Thanks for this, much welcome! I was supposed to give a better look at this during the long weekend but I was not able too. I see that you are still sometimes adding commits, is this ready for review/merge or you have plans for adding/changing stuff?

@beef331
Copy link
Contributor Author

beef331 commented Apr 19, 2022

It's probably fine now, there were issues with it prior that I realized after

@pietroppeter
Copy link
Owner

sorry about letting this sit here so long, last two/three months I had very little time for nim stuff. I have a bit of backlog to catch up now but realistically I should be able to look and merge (along with a new release of nimibook) by the end of July (last words...).

@beef331
Copy link
Contributor Author

beef331 commented Jun 28, 2022

It's fine by me it was like less than an hour of work so it's not a big deal.

@pietroppeter
Copy link
Owner

thanks for this! had time to check it out and it does indeed work as expected. Will now merge and work on documenting last changes and adding netlify preview before releasing 0.3

@pietroppeter pietroppeter merged commit 3e6723a into pietroppeter:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants