ImediateAlertService::NoAlert doesn't dissmiss phone call on PineTime

[jmlich]

When phone call comes following notifications appears on the PineTime:

• Incoming call notification (with answer/hangup/silence buttons)
• Immediate Alert Notification with level No Alert when call is ended

I have traced the problem to the following code:

if (m_voiceCallController.ringing()) {
    m_device->incomingCall(caller);
} else {
   m_device->immediateAlert(ImmediateAlertService::No_Alert);
}

Namely, I am referring to this function (Line 200):

harbour-amazfish/daemon/src/deviceinterface.cpp

Lines 188 to 202 in b56b589

	if (m_voiceCallController.ringing()) {
	QString caller = m_voiceCallController.findPersonByNumber(m_voiceCallController.callerId());
	if (AmazfishConfig::instance()->appTransliterate()) {
	m_device->incomingCall( Transliterator::convert( caller ) );
	} else {
	m_device->incomingCall(caller);
	}
	} else {
	if (m_device->service("00001802-0000-1000-8000-00805f9b34fb")){
	m_device->service("00001802-0000-1000-8000-00805f9b34fb")->writeValue("00002a06-0000-1000-8000-00805f9b34fb", QByteArray(1, 0x00)); //TODO properly abstract immediate notification service
	}
	}

On the PineTime, this code results in a notification displaying the text "No Alert," which is not the intended behavior. According to the InfiniTime code, there currently isn't a way to dismiss this notification. I was checking also GadgetBridge and it doesn't specify any action to dismiss phone call in PineTime part of code

https://github.com/Freeyourgadget/Gadgetbridge/blob/0f7fa7593130a51d7d95a90301cdfe1bd63ba447/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/devices/pinetime/PineTimeJFSupport.java#L405

I recommend adding a device-specific function, m_device->incomingCallEnded();, which will send the Immediate Alert Service "No Alert" message only for devices where it is appropriate.

I wasn't able to track it for other devices, because I don't understand how TransactionBuilder oricess performInitialized("end call").

Do we have information about which devices the original code was functioning correctly for?

I guess I will update also #289 according to that.