Skip to content
This repository has been archived by the owner on Oct 16, 2022. It is now read-only.

Some album art are not showing, while others do. #70

Closed
taylorsalez opened this issue Mar 27, 2022 · 4 comments
Closed

Some album art are not showing, while others do. #70

taylorsalez opened this issue Mar 27, 2022 · 4 comments

Comments

@taylorsalez
Copy link

taylorsalez commented Mar 27, 2022

I went and tagged every video file (around 77) with the title, album (which is the required one), and other tags.
I created a thumbnail for each video file, uploaded them all to the discord app.

I followed the instructions in ADVANCED.md.

The weird thing is, some do show an album art in the Discord rich presence, while others simply do not.

I have checked tags, codec, format, tag versions, file names, etc... there is no difference between a working mp4 file, and a non-working mp4 file. Same syntax, didn't forget the comas, proper spacing, etc...

Weirdly enough, every mkv file works (Matroska tags),, the inconsistency only happens with MP4 files.
Matroska

MP4 file working correctly:
mp4 working

MP4 file not working correctly:
mp4 not working

art.json file:
Capture

@taylorsalez
Copy link
Author

Update: it seems some album art appear for half a second sometimes, then disappear.

@Pigpog
Copy link
Owner

Pigpog commented May 15, 2022

Sorry for the months of silence. I just did some investigating, and i have a question. Are these downloaded YouTube videos?
I (coincidentally) tried to reproduce this with a downloaded YouTube video and found that my code recognizes it as a YouTube video using some metadata, and tries to show the YouTube large icon (which you probably don't have in your Application).

To fix this issue, then, you can either remove the "Youtube Start Time" metadata tag from each video, or delete lines 30 - 33 of format.js.

I never anticipated the album art feature being used for videos, so I never tested that. But there's clearly no technical reason preventing this. A slight modification of the code would allow a TV show name to be used for the large image as well.

Hope this helps, sorry again for the delay, thanks for the challenge

@taylorsalez
Copy link
Author

No worries about the delay!

Yeah, those are all Youtube videos I downloaded, cleared the metadata from, and re-tagged.
I ended up taking a day to convert every file to MKV, and only one file still did not work.

I turned line 30-33 into comment lines and it works now, thanks!

@Pigpog
Copy link
Owner

Pigpog commented May 15, 2022

Awesome, glad I noticed that the YouTube metadata lingers in youtube-dl files, or i'd be so lost as to what the problem could be.
Have a good one!

@Pigpog Pigpog closed this as completed May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants