Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better errors in readDefaultConfig, make chooseFromList more space-tolerant #54

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Conversation

orichters
Copy link
Contributor

@orichters orichters commented Feb 16, 2023

  • Let readDefaultConfig tell you which file it couldn't find and where.
  • chooseFromList now also accept 1, 3 with a space somewhere inside as input, of course only as long as the parser can understand it.
  • Improve description of returnBoolean option

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.20 🎉

Comparison is base (4448e22) 33.02% compared to head (28c32bf) 33.23%.

❗ Current head 28c32bf differs from pull request most recent head dda2775. Consider uploading reports for the commit dda2775 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   33.02%   33.23%   +0.20%     
==========================================
  Files          51       51              
  Lines        1647     1652       +5     
==========================================
+ Hits          544      549       +5     
  Misses       1103     1103              
Impacted Files Coverage Δ
R/readDefaultConfig.R 81.81% <75.00%> (-18.19%) ⬇️
R/chooseFromList.R 72.13% <80.00%> (-0.76%) ⬇️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@orichters orichters merged commit 818eaac into pik-piam:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants