included electricity imports in the reporting #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also note the addition of a test script for limesMapping. I think it would be possible to simplify the function and maybe to split it into two functions (one for identifying the regional dimension, one for renaming the regions), but I was not sure which problematic cases existed that the function should handle. Adding tests for these specific cases would be great to improve the function (unless we can drop it by changing the LIMES region naming, my preferred option) |
|
I will be
out of the
office until 20
August 2022. In urgent cases please
contact Michael Pahle ***@***.***).
Thank you for
your message.
--
Sebastian Osorio
Postdoc researcher of working group "Climate & Energy Policies"
Research Domain III: Transformation Pathways
Tel: +49 331 2882436
E-mail: ***@***.***
Potsdam Institute for Climate Impact Research (PIK)
Telegraphenberg A 31
P.O. Box 60 12 03
D-14412 Potsdam
www.pik-potsdam.de
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check:
Note: limesMapping should not be necessary if LIMES adopted a 3-letter region code. Even if it had a consistent 2-letter region code (excluding 'Balkan'), it would be possible to make a case for as.magpie to include an option to recognize 2-letter regions