Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of items that were renamed due to the mudularization of the LIMES GAMS code #2

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

dklein-pik
Copy link
Member

No description provided.

…exists in one of ('any') the dimensions of var

- Add new variable names where read from gdx
p_taulength -> pm_taulength
v_cap -> vm_cap
c_emicappathscen -> cm_emicappathscen
v_emi -> vm_emi
q_emicappath1 -> q30_emicappath1
q_emicappath2 -> q30_emicappath2
p_emifac -> p30_emifac
v_pedem -> vm_pedem
@dklein-pik dklein-pik requested a review from piklev June 29, 2022 07:52
Copy link
Contributor

@piklev piklev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one note that should probably be removed.
Also, isn't it problematic to have the new name after the old name in readGDX? (for instance having readGDX(name = c("p_taulength", "pm_taulength", ...) insteand of readGDX(name = c("pm_taulength", "p_taulength", ...) ? What would happen if the gdx has the two parameters/variables because of inheritance issue? Would it then select the old parameter/variable?

@dklein-pik
Copy link
Member Author

There is still one note that should probably be removed. Also, isn't it problematic to have the new name after the old name in readGDX? (for instance having readGDX(name = c("p_taulength", "pm_taulength", ...) insteand of readGDX(name = c("pm_taulength", "p_taulength", ...) ? What would happen if the gdx has the two parameters/variables because of inheritance issue? Would it then select the old parameter/variable?

Didn't think about this. How can that happen? And if both parameters are present in the gdx, why is the new one then the better one?

@dklein-pik
Copy link
Member Author

There is still one note that should probably be removed.

Yes, I cant do it today. Hopefully tomorrow.

@piklev
Copy link
Contributor

piklev commented Jun 29, 2022

Didn't think about this. How can that happen? And if both parameters are present in the gdx, why is the new one then the better one?

For the time that the older LIMES version is still being used, having the vm/pm/q30 in the first position might be problematic for the reporting if both names are in the GDX (but I do not think a new gdx would be used for runs in the older LIMES version). Otherwise, I would think the risk of an old GDX used with the new LIMES version to be higher.

@piklev piklev merged commit c697b71 into pik-piam:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants