-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various status badges #4
Labels
effort: 3
A few days of work.
priority: low
Nice to have, but nobody is going to be sad if this is never done.
type: feature
Comments
msimberg
added
effort: 3
A few days of work.
priority: low
Nice to have, but nobody is going to be sad if this is never done.
type: feature
labels
Jan 18, 2022
bors bot
added a commit
that referenced
this issue
Aug 8, 2022
330: Update CUDA sender functionality to work with P2300 reference implementation r=msimberg a=msimberg Continuation of #315. Part 2/n to fix #302. This has now been tested with clang 14 and CUDA. ~but a CI configuration will follow in a separate PR (the llvm build requires this patch: spack/spack#31661 - Makes `get_env` customizations `noexcept` as required (and enforced) by the P2300 reference implementation. - Add a missing `range` header to `cuda_scheduler_bulk.hpp`. - ADL-isolate sender and receiver types in `async_cuda` module. - Fixes the `completion_signatures` for senders in `async_cuda`. Note that the helpers for computing the types have to be guarded with a `requires is_invocable_v...` because `make_completion_signatures` instantiates the helper with non-`set_value_t` signatures as well. I have to investigate whether this is a bug or expected behaviour. - Because of the above, a number of helper "kernels" have received trailing `decltype`s to enable SFINAE with bogus arguments. - Removes the SFINAE for `then_with_cuda_stream` etc. since the HIP branch has been merged into DLA-Future. The SFINAE is no longer needed for choosing a `then_with_*` overload and adds unnecessary complexity. - The reference implementation's `split` does not yet support move-only senders, so some additional tests are disabled with CUDA and the reference implementation. - Change the `clang-14` Jenkins configuration to use CUDA and the P2300 reference implementation. Note, this is not for 0.7.0 as it needs more work. Reviews are, however, already welcome. 346: Remove `operator|` overloads for `sync_wait` and `start_detached` r=msimberg a=msimberg Fixes #329 . 347: Add Codacy coverage report r=msimberg a=msimberg Part of #4. Not fully tested, but I got some reporting already to Codacy so there is hope that this works... To do: - [x] badge 352: Increase timeout for container algorithms tests on macOS CI configuration r=msimberg a=msimberg I'm increasing the timeout to check if these timeouts https://github.com/pika-org/pika/runs/7692289838?check_suite_focus=true#step:6:237 are simply due to the test taking long to complete or if it really hangs. `partial_sort_copy_range` is one of the longer running tests so it's possible that it indeed just doesn't have enough time to finish (the timeout is 120 seconds and one of the later runs finished in 101 seconds: https://github.com/pika-org/pika/runs/7691710341?check_suite_focus=true#step:6:237). Co-authored-by: Mikael Simberg <simberg@cscs.ch> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Aug 8, 2022
347: Add Codacy coverage report r=msimberg a=msimberg Part of #4. Not fully tested, but I got some reporting already to Codacy so there is hope that this works... To do: - [x] badge 352: Increase timeout for container algorithms tests on macOS CI configuration r=msimberg a=msimberg I'm increasing the timeout to check if these timeouts https://github.com/pika-org/pika/runs/7692289838?check_suite_focus=true#step:6:237 are simply due to the test taking long to complete or if it really hangs. `partial_sort_copy_range` is one of the longer running tests so it's possible that it indeed just doesn't have enough time to finish (the timeout is 120 seconds and one of the later runs finished in 101 seconds: https://github.com/pika-org/pika/runs/7691710341?check_suite_focus=true#step:6:237). Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
bors bot
added a commit
that referenced
this issue
Aug 8, 2022
330: Update CUDA sender functionality to work with P2300 reference implementation r=msimberg a=msimberg Continuation of #315. Part 2/n to fix #302. This has now been tested with clang 14 and CUDA. ~but a CI configuration will follow in a separate PR (the llvm build requires this patch: spack/spack#31661 - Makes `get_env` customizations `noexcept` as required (and enforced) by the P2300 reference implementation. - Add a missing `range` header to `cuda_scheduler_bulk.hpp`. - ADL-isolate sender and receiver types in `async_cuda` module. - Fixes the `completion_signatures` for senders in `async_cuda`. Note that the helpers for computing the types have to be guarded with a `requires is_invocable_v...` because `make_completion_signatures` instantiates the helper with non-`set_value_t` signatures as well. I have to investigate whether this is a bug or expected behaviour. - Because of the above, a number of helper "kernels" have received trailing `decltype`s to enable SFINAE with bogus arguments. - Removes the SFINAE for `then_with_cuda_stream` etc. since the HIP branch has been merged into DLA-Future. The SFINAE is no longer needed for choosing a `then_with_*` overload and adds unnecessary complexity. - The reference implementation's `split` does not yet support move-only senders, so some additional tests are disabled with CUDA and the reference implementation. - Change the `clang-14` Jenkins configuration to use CUDA and the P2300 reference implementation. Note, this is not for 0.7.0 as it needs more work. Reviews are, however, already welcome. 347: Add Codacy coverage report r=msimberg a=msimberg Part of #4. Not fully tested, but I got some reporting already to Codacy so there is hope that this works... To do: - [x] badge Co-authored-by: Mikael Simberg <simberg@cscs.ch> Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>
I'm closing this. We don't have the jenkins badges but I'm not sure we can have those with the current jenkins configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: 3
A few days of work.
priority: low
Nice to have, but nobody is going to be sad if this is never done.
type: feature
coverallsCodacy (Add Codacy coverage report #347)The text was updated successfully, but these errors were encountered: